fix sleep on non-renewable vault secrets #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-mang
reviewed
Sep 5, 2019
An over-zealous refactoring resulted in <-time.After() channel used for non-renewable sleep to be ignored. I originally had channel of the time channels but "simplified" it too much. This reworks it the way the sleep is passed to the next iteration to just pass the time.Duration of the sleep down the channel, then time.Sleep-ing when reading off the channel. This way it can see it has a sleep to do, then do it instead of skipping it as the time hadn't passed yet. This also let me write a test for it as I don't need to actually sleep to see that there is something in the channel. Fixes #1272
eikenb
force-pushed
the
issue-1272-vault-sleep-fix
branch
from
ef7e4b5
to
9d0543c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An over-zealous refactoring resulted in <-time.After() channel used for
non-renewable sleep to be ignored. I originally had channel of the time
channels but "simplified" it too much. This reworks it the way the sleep
is passed to the next iteration to just pass the time.Duration of the
sleep down the channel, then time.Sleep-ing when reading off the
channel. This way it can see it has a sleep to do, then do it instead of
skipping it as the time hadn't passed yet.
This also let me write a test for it as I don't need to actually sleep
to see that there is something in the channel.
Fixes #1272