Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sleep on non-renewable vault secrets #1277

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Commits on Sep 5, 2019

  1. fix sleep on non-renewable vault secrets

    An over-zealous refactoring resulted in <-time.After() channel used for
    non-renewable sleep to be ignored. I originally had channel of the time
    channels but "simplified" it too much. This reworks it the way the sleep
    is passed to the next iteration to just pass the time.Duration of the
    sleep down the channel, then time.Sleep-ing when reading off the
    channel. This way it can see it has a sleep to do, then do it instead of
    skipping it as the time hadn't passed yet.
    
    This also let me write a test for it as I don't need to actually sleep
    to see that there is something in the channel.
    
    Fixes #1272
    eikenb committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    9d0543c View commit details
    Browse the repository at this point in the history