make connect and health service ids different #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IDs need to be different as they are used as the cache keys and using the same ID means `connect` and `service` would overwrite each other if both used. (this is bad) The `connect` function re-uses the health `service` code as it is identical except for an additional option. When adding connect the ID was unintentially left the same, it should be different. Fixes #1458
findkim
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IDs need to be different as they are used as the cache keys and
using the same ID means
connectandservicewould overwrite eachother if both used. (this is bad)
The
connectfunction re-uses the healthservicecode as it isidentical except for an additional option. When adding connect the ID
was unintentially left the same, it should be different.
Fixes #1458