Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make connect and health service ids different #1474

Merged
merged 1 commit into from
May 27, 2021
Merged

make connect and health service ids different #1474

merged 1 commit into from
May 27, 2021

Commits on May 27, 2021

  1. make connect and health service ids different 

    The IDs need to be different as they are used as the cache keys and
using the same ID means `connect` and `service` would overwrite each
other if both used. (this is bad)

The `connect` function re-uses the health `service` code as it is
identical except for an additional option. When adding connect the ID
was unintentially left the same, it should be different.

Fixes #1458
    @eikenb
    eikenb committed May 27, 2021
    Configuration menu
    Copy the full SHA
    3d1fcf0 View commit details
    Browse the repository at this point in the history