Issue 1428 fix no reload signal #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted odd SIGNIL type that wouldn't work with syscall type assertion and allow for differentiating between it and an error into SIGNULL, `syscall.Signal(0)`. SIGNULL works here as it allows for the type assertion to work and for a test to skip the signal when found. It is safe as it already exists in practice in a similar role with the POSIX `kill` command where it indidates no signal. The other changes here are to replace reference to the hold SIGNIL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted odd SIGNIL type that wouldn't work with syscall type assertion and allow for differentiating between it and an error into SIGNULL,
syscall.Signal(0). SIGNULL works here as it allows for the type assertion to work and for a test to skip the signal when found. It is safe as it already exists in practice in a similar role with the POSIXkillcommand where it indidates no signal.Fixes #1428
Fixes #1442