Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1428 fix no reload signal #1610

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Issue 1428 fix no reload signal #1610

merged 2 commits into from
Aug 1, 2022

Commits on Jul 30, 2022

  1. skip reload signal if set to "" or signull 

    Converted odd SIGNIL type that wouldn't work with syscall type assertion
and allow for differentiating between it and an error into SIGNULL,
`syscall.Signal(0)`. SIGNULL works here as it allows for the type
assertion to work and for a test to skip the signal when found. It is
safe as it already exists in practice in a similar role with the POSIX
`kill` command where it indidates no signal.

The other changes here are to replace reference to the hold SIGNIL.
    @eikenb
    eikenb committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    ca15253 View commit details
    Browse the repository at this point in the history

  2. add tests on parsing and defaults of reload_signal

    @eikenb
    eikenb committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    84f227f View commit details
    Browse the repository at this point in the history