Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing err check to Vault read test #1682

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Add missing err check to Vault read test #1682

merged 1 commit into from
Dec 5, 2022

Conversation

thevilledev
Copy link
Contributor

A Vault related test in dependency/vault_read_test.go creates an operator policy for creating restricted tokens later on. The call is missing an err check and this PR fixes that.

@thevilledev thevilledev requested a review from a team December 4, 2022 18:15
eikenb
eikenb approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@eikenb eikenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked blame and it wasn't me. Whew. ;)

Thanks @vtorhonen for all the PRs fixing up the code. Helps keep the bit-rot at bay. ❤️

@eikenb eikenb merged commit f8888b0 into hashicorp:main Dec 5, 2022
@thevilledev
Copy link
Contributor Author

Happy to help & thanks @eikenb!

@thevilledev thevilledev deleted the chore/vault-fixes branch December 7, 2022 17:40
@thevilledev thevilledev mentioned this pull request Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikenb eikenb eikenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thevilledev @eikenb