chore(ci): add golangci-lint #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thevilledev
force-pushed
the
chore/golangci-lint
branch
from
54a0465
to
cdcb9b9
Compare
|
this is great, thank you so much for doing this. a couple of minor comments to address and this is read to go |
|
I was thinking about this too so I was working on: #1792 for mostly repo cleanup/maintenance. I will wait to get your PR merged before I proceed with mine |
|
Thanks @roncodingenthusiast for the review! AFK still today but I will address the changes tomorrow 👍 |
Co-authored-by: Ronald <roncodingenthusiast@users.noreply.github.com>
Co-authored-by: Ronald <roncodingenthusiast@users.noreply.github.com>
Co-authored-by: Ronald <roncodingenthusiast@users.noreply.github.com>
Co-authored-by: Ronald <roncodingenthusiast@users.noreply.github.com>
|
@thevilledev when you have a second, do you mind rebasing this? The other two PRs are merged so the lint errors should be fixed now |
|
Thanks @roncodingenthusiast! Tests are passing after rebase so updated the PR description and marked as ready for review |
roncodingenthusiast
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been preparing this for some time with the following PRs:
And I think we're ready for adding a Github Action for running the linters:
golangci-lintconfiguration based on the Consul project