Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate type field for boundary_account_password #396

Merged
merged 2 commits into from
May 9, 2023

Conversation

elimt
Copy link
Member

@elimt elimt commented May 5, 2023

The boundary_account_password resource has a required type field but the only valid value is "password." Deprecating the type field and setting a default value. Users will still be able to pass in a value for the type field. This will prevent existing configs from breaking.

Example: The missing type field will default to password.

resource "boundary_account_password" "jeff" {
 auth_method_id = boundary_auth_method.password.id
 login_name     = "jeff"
 password       = "$uper$ecure"
}

@elimt elimt changed the title chore: Deprecate type field for resource_account_password chore: Deprecate type field for boundary_account_password May 5, 2023
@elimt elimt requested review from ddebko and louisruch May 5, 2023 18:31
Copy link
Contributor

@ddebko ddebko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great

@elimt elimt merged commit 32c081a into main May 9, 2023
@elimt elimt deleted the elimt-remove-account-resource-type branch May 9, 2023 13:55
grantorchard pushed a commit to grantorchard/terraform-provider-boundary that referenced this pull request Aug 28, 2023
)

* Deprecate type field for boundary_account_password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants