Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate type field for boundary_account_ldap #400

Merged
merged 2 commits into from
May 10, 2023

Conversation

elimt
Copy link
Member

@elimt elimt commented May 9, 2023

The boundary_account_ldap resource has a required type field but the only valid value is "ldap". Deprecating the type field and setting a default value of ldap.

Users will still be able to pass in a value for the type field. This will prevent existing configs from breaking.

Example: The missing type field will default to ldap.

resource "boundary_account_ldap" "foo" {
   name           = "test name"
   description    = "test description"
   login_name     = "foo"
   auth_method_id = boundary_auth_method_ldap.foo.id
}

A similar change for boundary_account_password: #396

@elimt elimt requested review from jimlambrt and ddebko May 9, 2023 14:15
@elimt elimt added this to the 0.13.x milestone May 9, 2023
Copy link
Contributor

@jimlambrt jimlambrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@elimt elimt merged commit 8e413b2 into main May 10, 2023
@elimt elimt deleted the elimt-deprecate-ldap-account-type branch May 10, 2023 14:28
grantorchard pushed a commit to grantorchard/terraform-provider-boundary that referenced this pull request Aug 28, 2023
* deprecate type field for resource_account_ldap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants