Solver: Support dependencies on sub-libraries (issue #6039) (3rd iteration) #6836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tracks dependencies on sub-libraries by extending the functionality for tracking executables that was added in e86f838. It also starts adding support for library visibility, though it currently only works for source packages. There is a TODO for handling installed packages. This commit handles visibility similarly to the way that the buildable field is handled currently. It only checks whether a component is made private by the current environment and flag constraints at the start of dependency solving. This means that the solver can treat a component as visible when the visibility is controlled by an automatic flag, and the build can fail later, depending on the value that is chosen for the flag. Fixes haskell#6038.
This commit also refactors the Dependencies type so that it can represent any combination of dependencies, buildability, and visibility.
GHC <8.8 isn't able to read the "visibility" field from the package database, since it's built against an older Cabal. For this reason, using multiple public libraries with it did not work (all sublibraries appeared as private). This patch makes cabal-install override Cabal's library visibility checks when GHC is older than 8.8, extending the multiple libraries feature compatibiliy to older GHCs.
|
Oh, [ci skip] doesn't work anymore :-/ |
phadej
approved these changes
May 23, 2020
|
No. There is no easy check that [ci skip] tagged commit would be safe. CI is fast and reliable enough to just build everything.
… On 23. May 2020, at 19.08, Francesco Gazzetta ***@***.***> wrote:
Oh, [ci skip] doesn't work anymore :-/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I do see that it's waaay faster than before, thanks for that! And just to be clear, I'm merging this once it's green |
4 tasks
|
Thanks for finishing my PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds check overrides to #6812 / #6047
/cc @phadej @grayjay