Backport filter --allow-depending-on-private-libs #6838
Conversation
(cherry picked from commit 17b3fca)
|
Sorry, I didn't notice this patch was to 3.2 branch and not |
|
It isn't in master yet. It's part of #6836. By the way, could you restart https://ci.appveyor.com/project/23Skidoo/cabal/builds/33067141 so we can merge that too? I'm pretty sure that failure is just random |
|
Let's avoid backporting stuff which is not merged yet. Can #6836 merged as CI is done? Also you merged this even GitHub actions Windows 8.6.5 job was broken. Which is something I'm actively working on in #6828. I work hard to have especially release branches green, please don't merge if CI is not green. I should enforced the requirement for CI to be green for 3.2 branch too. Now it is. |
|
Yes, when #6836 is green we can add the changelog entry and merge. |
In #6836 I noticed that I forgot to filter out the --allow-depending-on-private-libs flag for old Cabals. With that patch it becomes necessary to have the filtering, but I guess having it in 3.2 would be good too?