Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions and deps on master branch to 3.11 and regenerate bootstrap files #8844

Merged
merged 8 commits into from
Mar 13, 2023

Conversation

Mikolaj
Copy link
Member

@Mikolaj Mikolaj commented Mar 13, 2023

This is a counterpart of #8799 but for master branch. Now it should not break CI, because cabal 3.10 is already on Hackage, so it can be performed. The opposite, it should fix some other problems on CI due to stable release change.

@Mikolaj Mikolaj added the squash+merge me Tell Mergify Bot to squash-merge label Mar 13, 2023
@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 13, 2023

It seems I need to update bootstrap files in the same PR to keep them compiling.

@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 13, 2023

And 3.10 is apparently too new yet for the Custom setup in cabal-testsuite. Perhaps it needs to wait until GHA provides it (not just ghcup)? In any case, let me downgrade to make it work again. The funny thing is, 3.10.1.0 works fine on 3.10 branch, but that's probably, because it takes it from in-place build.

@ulysses4ever
Copy link
Collaborator

ulysses4ever commented Mar 13, 2023

@Mikolaj the GHA already has verything possible (3.10, 9.6, etc.) — Andreas manages it these days.

I'm not super sure but I think for the testsuite to compile you need to simultaneously do two things

  • bump the versions everywhere (this PR)
  • bump the cabal version in the CI to 3.10

I tried the second in #8840 but it didn't go through because I didn't do the first. So it makes sense to rather do it here I think.

@ulysses4ever
Copy link
Collaborator

Well, my comment didn't take this into account: haskell/actions#202 (comment)

@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 13, 2023

I'm not sure about my hypothesis, either, but setting it to 3.10 failed and, I think, not even on Windows. Let's see...

@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 13, 2023

I invalidated your both reviews. I apologise --- I did not expect I will have to update bootstrap files in the same PR, hence I asked for reviews so early.

@Kleidukos
Copy link
Member

no worries 👍

@Mikolaj Mikolaj changed the title Bump versions and deps on master branch to 3.11 Bump versions and deps on master branch to 3.11 and regenerate bootstrap files Mar 13, 2023
@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 13, 2023

I have one more commit prepared where I bump Custom Setup cabal in cabal-testsuite to 3.10 and bump cabal to 3.10 in validate, as @ulysses4ever recommends and which is probably why it didn't work before. But let me see how this CI succeeds.

I'm going to fast-merge anyway, to let @ulysses4ever complete the overhaul in #8840.

@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 13, 2023

OK, all bootstraps passed and one validate did and nothing failed. Let me try the extra commit.

@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 13, 2023

Hah, @ulysses4ever: I see I need to steal your e6e07e8

@Mikolaj Mikolaj added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Mar 13, 2023
@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 13, 2023

Job "Validate ubuntu-20.04 ghc-prerelease" fails with lots of mentions of "setup.Cabal-3.9.0.0/installed-3.9.0.0". How come? It has to come from CI cache, right? Because it doesn't have access to cabal 3.9 from anywhere else. If so, clearing the cache should be enough or switching to 9.6.1.

@mergify mergify bot merged commit dfe7393 into haskell:master Mar 13, 2023
@Mikolaj
Copy link
Member Author

Mikolaj commented Mar 13, 2023

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2023

backport 3.10

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 13, 2023
…rap files (#8844)

* Bump versions on master branch to 3.11

* Try to fix CI by setting cabal-testsuite stable Cabal version to 3.8 back again

* Update bootstrap configuration

* Work around bounds problem with cabal-install-parsers

* Update bootstrap files

* Try to update the Custom setup cabal to 3.10 according to Artem's suggestion

* CI: cabal-3.10 compat: actions/cache has to go before cabal update

* Fix failing old GHC CI builds by adding XDG's ~/.local/bin to GITHUB_PATH

---------

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
(cherry picked from commit dfe7393)

# Conflicts:
#	.github/workflows/bootstrap.yml
#	Cabal-QuickCheck/Cabal-QuickCheck.cabal
#	Cabal-described/Cabal-described.cabal
#	Cabal-syntax/Cabal-syntax.cabal
#	Cabal-tree-diff/Cabal-tree-diff.cabal
#	Cabal/Cabal.cabal
#	Cabal/Makefile
#	Makefile
#	bootstrap/cabal-bootstrap-gen.cabal
#	bootstrap/linux-8.10.7.json
#	bootstrap/linux-9.0.2.json
#	bootstrap/linux-9.2.3.json
#	bootstrap/linux-9.2.6.json
#	bootstrap/linux-9.2.7.json
#	bootstrap/linux-9.4.4.json
#	cabal-install-solver/cabal-install-solver.cabal
#	cabal-install/cabal-install.cabal
#	cabal-install/src/Distribution/Client/Version.hs
#	cabal-testsuite/cabal-testsuite.cabal
#	doc/conf.py
#	solver-benchmarks/solver-benchmarks.cabal
ulysses4ever added a commit that referenced this pull request Mar 15, 2023
…rap files (#8844)

* Bump versions on master branch to 3.11

* Try to fix CI by setting cabal-testsuite stable Cabal version to 3.8 back again

* Update bootstrap configuration

* Work around bounds problem with cabal-install-parsers

* Update bootstrap files

* Try to update the Custom setup cabal to 3.10 according to Artem's suggestion

* CI: cabal-3.10 compat: actions/cache has to go before cabal update

* Fix failing old GHC CI builds by adding XDG's ~/.local/bin to GITHUB_PATH

---------

Co-authored-by: Artem Pelenitsyn <a.pelenitsyn@gmail.com>
ulysses4ever added a commit that referenced this pull request Mar 30, 2023
undo 6bd17fc from #8844; the change was made in response to an issue
that was later fixed on the haskell/action side
ulysses4ever added a commit that referenced this pull request Mar 30, 2023
undo 6bd17fc from #8844; the change was made in response to an issue
that was later fixed on the haskell/action side
ulysses4ever added a commit that referenced this pull request Mar 30, 2023
undo 6bd17fc from #8844; the change was made in response to an issue
that was later fixed on the haskell/action side
ulysses4ever added a commit that referenced this pull request Apr 1, 2023
undo 6bd17fc from #8844; the change was made in response to an issue
that was later fixed on the haskell/action side
ulysses4ever added a commit that referenced this pull request Apr 3, 2023
undo 6bd17fc from #8844; the change was made in response to an issue
that was later fixed on the haskell/action side
mergify bot pushed a commit that referenced this pull request Apr 5, 2023
undo 6bd17fc from #8844; the change was made in response to an issue
that was later fixed on the haskell/action side

(cherry picked from commit 3b8e6e9)

# Conflicts:
#	.github/workflows/validate.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-review merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days release squash+merge me Tell Mergify Bot to squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants