Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add GHC 9.6.1 #8840

Merged
merged 12 commits into from
Apr 5, 2023
Merged

CI: add GHC 9.6.1 #8840

merged 12 commits into from
Apr 5, 2023

Conversation

ulysses4ever
Copy link
Collaborator

@ulysses4ever ulysses4ever commented Mar 12, 2023

Time to rock 🤘

Usual Blockers

Unusual Blockers

TODO

  • create an issue for the "double directory" issue and make sure *-suite validation is reenabled after it's solved.

  • Bump minor versions of the previous computer series. Don't forget about GHC_FOR_RELEASE and the friends.

@Mikolaj
Copy link
Member

Mikolaj commented Mar 13, 2023

@ulysses4ever: would perhaps bumping cabal on master to 3.11 help with this? If so, I can prioritize.

@ulysses4ever
Copy link
Collaborator Author

@Mikolaj oh it hasn't been? I think that's the reason of one of the failures, yes (number three in the "Usual blockers" list in OP). There's no rush though: do it when you feel it's the time. This PR can wait.

It seems that putting cache-restore in front did help with haskell/actions#203

@Mikolaj
Copy link
Member

Mikolaj commented Mar 13, 2023

Version bumps on master: #8844

@ulysses4ever
Copy link
Collaborator Author

I rolled back cabal install in CI to 3.8 because on this branch the versions have not been updated and therefore cabal-testsuite requires 3.8. But I get a failure "All install methods for cabal 3.8.1.0 failed" foir some reason...:

It didn't happen with 3.10...

@Mikolaj
Copy link
Member

Mikolaj commented Mar 13, 2023

This seems broken upstream. Let's see if it works fine (again with 3.10) once the version bump PR lands.

Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, rock and roll!!

It seems like you accidentially but effectively turned of caching of ~/.cabal/store.

.github/workflows/validate.yml Show resolved Hide resolved
.github/workflows/validate.yml Outdated Show resolved Hide resolved
.github/workflows/validate.yml Outdated Show resolved Hide resolved
@andreasabel
Copy link
Member

@ulysses4ever wrote:

But I get a failure "All install methods for cabal 3.8.1.0 failed" foir some reason...:

Well this is exactly haskell/actions#202, as analysed by @Mistuke: The setup action installs cabal 3.10.1.0 already with ghc, and then the subsequent attempt to install 3.8.1.0 chokes when trying to handle the 3.10.1.0 generated config file.

@ulysses4ever
Copy link
Collaborator Author

@andreasabel well, I must say: you put it much more clear than I was able to distill from that thread. Thank you!

I thought some sort of workaround had been deployed though? Mistuke said that it should be 3.8 now? I can try to explicitly rm the config perhaps.

@ulysses4ever
Copy link
Collaborator Author

Otherwise, thanks for the review! I'll look into actionlint.

@Mikolaj
Copy link
Member

Mikolaj commented Mar 13, 2023

The master version bump PR is merged.

@andreasabel
Copy link
Member

@ulysses4ever : I fixed the haskell setup action v2 now, based on the advice by @Mistuke. Please try again!

@ulysses4ever
Copy link
Collaborator Author

Oh no, why is it trying to build Cabal-syntax-3.8.1.0... https://github.com/haskell/cabal/actions/runs/4409245230/jobs/7728945807#step:13:788

@Mikolaj
Copy link
Member

Mikolaj commented Mar 14, 2023

Oh no, why is it trying to build Cabal-syntax-3.8.1.0... https://github.com/haskell/cabal/actions/runs/4409245230/jobs/7728945807#step:13:788

How about rebasing on master (with the version bumps)?

@ulysses4ever
Copy link
Collaborator Author

How about rebasing on master (with the version bumps)?

Well, this is a good point and a possibility I had in mind. But I thought that moving one thing at a time (in this case, the version of GHC) may be easier. I can try to rebase, yes. I may not have time to for a day or two though.

@Mikolaj
Copy link
Member

Mikolaj commented Mar 14, 2023

No rush. BTW, yet another possibility for the CI cache problem resolution may be to reset the whole cache (first only in the PR, to verify) and so switch to XDG completely. Then the result of cabal update is properly found and used.

@ulysses4ever ulysses4ever force-pushed the ci-9.6.1 branch 2 times, most recently from 3f8fa8c to d668620 Compare March 15, 2023 02:11
@haskell haskell deleted a comment from mergify bot Mar 15, 2023
@ulysses4ever ulysses4ever force-pushed the ci-9.6.1 branch 2 times, most recently from ab06a99 to 1f8606c Compare March 15, 2023 02:42
@ulysses4ever
Copy link
Collaborator Author

ulysses4ever commented Mar 15, 2023

All right, useless GitHub wouldn't run CI because of conflicts with master (TIL...), so I had to rebase on master and, therefore, pull the versions bump from #8844. Now let's see...

Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!!

@ulysses4ever ulysses4ever added the merge me Tell Mergify Bot to merge label Apr 1, 2023
@ulysses4ever
Copy link
Collaborator Author

@Mikolaj on the topic of bumping minor versions. Our GHC_FOR_RELEASE is currently at 9.2.3. Do you want me to bump it to 9.2.7 or leave the 9.2 series alone. We could also have two 9.2.x compilers, I presume.

@Mikolaj
Copy link
Member

Mikolaj commented Apr 3, 2023

Yes, I think bumping it all makes sense and I'd keep only the newest version. I waited with touching the gitlab script until after the release, so this is a good moment now.

@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Apr 5, 2023
@mergify mergify bot merged commit 6f9acee into master Apr 5, 2023
@ulysses4ever
Copy link
Collaborator Author

@mergify backport 3.10

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

backport 3.10

✅ Backports have been created

@Mikolaj
Copy link
Member

Mikolaj commented Apr 5, 2023

Hurray!

@ulysses4ever
Copy link
Collaborator Author

Yep, this was a long ride. Not sure when I have energy to attend to a backport...

Kleidukos added a commit to Kleidukos/cabal that referenced this pull request Apr 6, 2023
Kleidukos added a commit to Kleidukos/cabal that referenced this pull request Apr 6, 2023
Kleidukos added a commit to Kleidukos/cabal that referenced this pull request Apr 20, 2023
@ulysses4ever ulysses4ever deleted the ci-9.6.1 branch April 21, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-help Help wanted with this issue/PR continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants