Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ghc-8.8.4 #206

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Add support for ghc-8.8.4 #206

merged 3 commits into from
Jul 17, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented Jul 17, 2020

  • Updating hackage index to get last version of ghc-exactprint, compatible with ghc-8.8.4
  • Adding a stack-8.8.4.yaml using the last ghc-8.8.3 resolver but informing explicitly compiler: ghc-8.8.4

I am getting errors compiling floskell in windows, but it is reproduced with other ghc versions. I get to compile downloading floskell locally and adding it as subpackage in cabal.project.
To report upstream 🤷‍♂️ : ennocramer/floskell#50

@jneira jneira changed the title Add support for ghc-8.4.4 Add support for ghc-8.8.4 Jul 17, 2020
Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@alanz alanz merged commit 751428c into haskell:master Jul 17, 2020
@jneira jneira deleted the ghc-8.8.4 branch July 17, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants