Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -haddock for cabal and stack #214

Merged
merged 5 commits into from
Jul 23, 2020
Merged

Use -haddock for cabal and stack #214

merged 5 commits into from
Jul 23, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented Jul 20, 2020

@jneira jneira requested review from fendor and pepeiborra July 20, 2020 22:07
@georgefst
Copy link
Collaborator

To be pedantic, I think the info is in the .hi files, rather than .hie files.

stack-8.6.5.yaml Outdated Show resolved Hide resolved
@jneira
Copy link
Member Author

jneira commented Jul 22, 2020

The stricter parser is throwed an error with hls itself:

Progress 33/35: haskell-language-serve  > /root/build/test/functional/Deferred.hs:162:9: error:
Progress 33/35: haskell-language-server  >     parse error on input ‘-- $ runSession hieCommand fullCaps "test/testdata" $ do’
Progress 33/35: haskell-language-server  >     |
Progress 33/35: haskell-language-server  > 162 |         -- $ runSession hieCommand fullCaps "test/testdata" $ do
Progress 33/35: haskell-language-server  >     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

To avoid parse error with -haddock ghc option enabled
@jneira
Copy link
Member Author

jneira commented Jul 23, 2020

Parser errors solved so merging

@jneira jneira merged commit 12c0e44 into haskell:master Jul 23, 2020
@jneira jneira deleted the ghc-haddock branch July 23, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants