Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand_selection to current node with no children #1454

Conversation

the-mikedavis
Copy link
Member

@the-mikedavis the-mikedavis commented Jan 6, 2022

builds on the work in #919 so we can expand selections when on a terminal node of the tree.

before:

before.mp4

after:

after.mp4

Where in this case the tree looks like

(arguments (identifier) (identifier))

So expand_selection will grow the current selection to fit the node ((identifier)), or grow to the parent ((arguments (identifier) (identifier))) if the current node is already fully selected. IMHO this is more intuitive. What do you think?

@archseer archseer merged commit 939261f into helix-editor:master Jan 8, 2022
@the-mikedavis the-mikedavis deleted the md-expand-selection-grow-to-fit-node-with-no-children branch January 8, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants