Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add repeat expand_selection and select smaller range at some case #919

Merged
merged 2 commits into from
Oct 29, 2021
Merged

add repeat expand_selection and select smaller range at some case #919

merged 2 commits into from
Oct 29, 2021

Conversation

cossonleo
Copy link
Contributor

@cossonleo cossonleo commented Oct 27, 2021 •
edited
Loading

Like title,
Before select smaller range

simplescreenrecorder1-2021-10-28_13.36.00.mp4

:

After:

simplescreenrecorder1-2021-10-28_13.37.42.mp4

@cossonleo cossonleo changed the title add expand_selection to last_motion add repeat motion to expand_selection Oct 27, 2021
@cossonleo cossonleo changed the title add repeat motion to expand_selection add repeat motion for expand_selection Oct 27, 2021
@cossonleo cossonleo changed the title add repeat motion for expand_selection add repeat motion with expand_selection Oct 27, 2021
@archseer
Copy link
Member

Can you rebase? I fixed the tests on master.

@cossonleo
Copy link
Contributor Author

Can you rebase? I fixed the tests on master.

Already rebased.

@cossonleo cossonleo changed the title add repeat motion with expand_selection add repeat expand_selection and select smaller range at some case Oct 28, 2021
archseer
archseer approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍🏻

@archseer archseer merged commit befecc8 into helix-editor:master Oct 29, 2021
@cossonleo cossonleo deleted the repeat_expand_selection branch October 29, 2021 02:23
@the-mikedavis the-mikedavis mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cossonleo @archseer