Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: newsletter api endpoint and payload #400

Merged
merged 14 commits into from
Feb 28, 2024
Merged

Conversation

ankyc-phi
Copy link
Collaborator

@ankyc-phi ankyc-phi commented Feb 21, 2024

Includes:

  • changed base uri, and updated api key
  • updated form payload (+ country, - date)
  • request payload and headers updated
  • base uri is using the reverse proxy cdn setup

Jira Issues:
https://pethealthinc.atlassian.net/browse/PM-143

Related: #405

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Feb 21, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Feb 21, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to feat-update-newsletter-api February 21, 2024 16:57 Inactive
Copy link
Collaborator

@ramboz ramboz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instrumentation looks good, but we need to look into the CORS issues and get those resolved if we don't want to lose current capabilities.

@aem-code-sync aem-code-sync bot temporarily deployed to feat-update-newsletter-api February 22, 2024 15:11 Inactive
Base automatically changed from sprint4-deploy to main February 22, 2024 16:08
@aem-code-sync aem-code-sync bot temporarily deployed to feat-update-newsletter-api February 23, 2024 20:04 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to feat-update-newsletter-api February 27, 2024 20:07 Inactive
@ankyc-phi
Copy link
Collaborator Author

ankyc-phi commented Feb 27, 2024

hoping to push this in by end of day, just fixed linting errors and merged the base branch

@aem-code-sync aem-code-sync bot temporarily deployed to feat-update-newsletter-api February 27, 2024 22:02 Inactive
@ankyc-phi
Copy link
Collaborator Author

pushing this live now, already approved and passed linting

@ankyc-phi ankyc-phi merged commit 49f9fbe into main Feb 28, 2024
1 of 2 checks passed
@ankyc-phi ankyc-phi deleted the feat-update-newsletter-api branch February 28, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants