feat: add reverse proxy worker for newsletter signup #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
ankyc-phi
reviewed
Feb 23, 2024
worker/fastly.toml
Outdated
|
|
||
| [[local_server.secret_stores.services_secrets]] | ||
| key = "newsletter_client_id" | ||
| data = "gqn2wsm10glznu7m3vjpv3i3" |
There was a problem hiding this comment.
does having the client id and client secret out in the open cause an issue in terms of data security??
There was a problem hiding this comment.
Yes 🤦🏼 That wasn't intended!
ramboz
force-pushed
the
reverse-proxy
branch
from
0ddcddb
to
1283ec0
Compare
ankyc-phi
added a commit
that referenced
this pull request
Feb 28, 2024
Includes: - changed base uri, and updated api key - updated form payload (+ country, - date) - request payload and headers updated - base uri is using the reverse proxy cdn setup Jira Issues: https://pethealthinc.atlassian.net/browse/PM-143 Related: #405 Test URLs: - Before: https://main--petplace--hlxsites.hlx.page/ - After: - https://feat-update-newsletter-api--petplace--hlxsites.hlx.live/ - https://feat-update-newsletter-api--petplace--hlxsites.hlx.live/?martech=off --------- Co-authored-by: Julien Ramboz <ramboz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the code for the reverse-proxy compute action that will run on the Fastly CDN and proxy the calls for the newsletter.