Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: demo new experimentation features #63

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: demo new experimentation features #63

wants to merge 4 commits into from

Conversation

ramboz
Copy link
Collaborator

@ramboz ramboz commented Mar 26, 2024 •
edited
Loading

This PR leverages the upcoming v2 of the experimentation engine (https://github.com/adobe/aem-experimentation) and serves as a demo setup for the new engine.

This will cover:

  • experiments
  • campaigns
  • audiences
    and support use cases for:
  • Page-level modifications
  • Section-level modifications
  • Block/fragment-level modifications

Test URLs:

@ramboz
Squashed 'plugins/experimentation/' changes from d2028dc..e02b92a
35a8732 
e02b92a feat: add support for experimentation
c80c985 feat: add support for experimentation
e04a21c fix: fetch without plain selector (#19)
4b4a853 fix: active status sanitization
4b6fa0d feat: add support for setting experiment status, start date and end date
0b293f1 fix: always await replaceInner (#18)
3ec48c9 fix: invalid url when given a path for variant (#14)
d9f3d01 fix: issue 11 (#12)
9e7b01a fix: expose resolved audiences when running campaigns
e79706d fix: make sure the pill is not shown on live and prod hosts
21890bb fix: improve production host detection to better cover edge cases
2034373 fix: pill does not show any results even if RUM endpoint contains data
53696f4 fix: RUM endpoint url returns empty results
fee6692 Update README.md
46e6a48 Update README.md
4ff6246 fix: leaking heading styles into the pill
02617d2 fix: sanitize experiment and variant names for proper css class injection
d6318cf fix: gracefully handle projects where block-level experiments aren't instrumented
162896d Update README.md
06a92c5 feat: update plugin to leverage v3 RUM APIs and domain key (#10)
b033075 doc: add warning about recent sampleRUM
b4d3dab fix: track rum when selected variant is control (#9)

git-subtree-dir: plugins/experimentation
git-subtree-split: e02b92a0a46a2c2d3dbb111f63859b613303ef9d
@ramboz
Merge commit '35a8732151a2d81f3128ce988c9bce2c0c4975f7' into experime…
320925f 
…ntation-v2
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 26, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Mar 26, 2024

Page Scores Audits Google
/drafts/akho/audiences/block Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/audiences/combined Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/audiences/page Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/audiences/section Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/campaigns/block Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/campaigns/combined Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/campaigns/page Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/campaigns/section Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/combined Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/experiments/block Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/experiments/combined Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/experiments/page Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/drafts/akho/experiments/section Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI

@ramboz
Squashed 'plugins/experimentation/' changes from e02b92a..0fb66e4
7b8a117 
0fb66e4 feat: add support for experimentation

git-subtree-dir: plugins/experimentation
git-subtree-split: 0fb66e4dd6f28ac0c2d1b858b2551bce1e0a28a6
@ramboz
Merge commit '7b8a1175d9647809cc930f15a8d8d3feb2827d41' into experime…
de2e7d1 
…ntation-v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ramboz