Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BME680: Minor fix to configuration validation and related log line. #11898

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

arcsur
Copy link
Contributor

@arcsur arcsur commented Jan 24, 2018

Description:

This is a minor fix to a voluptuous configuration type check that was set as string but should have been int. This did not stop the code from working but may have caused invalid error messages with a string value that could not be converted properly such as a config typo.

Note that the documentation, already states int correctly.

Related issue (if applicable): N/A

**Pull request in home-assistant.github.io with documentation (if applicable): N/A no change

Checklist:

  • The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • [N/A] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • [N/A] New dependencies are only imported inside functions that use them ([example][ex-import]).
  • [N/A] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [N/A] New files were added to .coveragerc.

@arcsur arcsur changed the title Minor fix to configuration validation and related log line. BME680: Minor fix to configuration validation and related log line. Jan 24, 2018
@arcsur
Copy link
Contributor Author

arcsur commented Jan 25, 2018

Something failed in the test case for the travis build but this is not related to my code which passed local tests. It seems to be something related to the Travis build environment missing a component (unrelated to this PR) for the Python 3.5.3 environment only.

I don't know how to request the Travis build to retry without submitting further changes.

Please assist.

@arcsur
Copy link
Contributor Author

arcsur commented Jan 25, 2018

@balloob @MartinHjelmare

Since you have previously reviewed my code....

Could you please help take a look at the Travis build for this. I believe the issue is not with my code but with the Travis build for 3.5.3. The error is it can't find the beer.py custom_component. This appears to be related to your testing setup and not my code.

@MartinHjelmare
Copy link
Member

I restarted the Travis build. You can do that yourself by closing and reopening the PR.

@arcsur
Copy link
Contributor Author

arcsur commented Jan 26, 2018

@MartinHjelmare Thanks. Will remember that for future.

@balloob balloob merged commit 3aa3130 into home-assistant:dev Jan 26, 2018
@balloob balloob mentioned this pull request Jan 26, 2018
matemaciek pushed a commit to matemaciek/home-assistant that referenced this pull request Jan 27, 2018
* upstream/master: (465 commits)
  Update pyhomematic to 0.1.38 (home-assistant#11936)
  Implement Alexa temperature sensors (home-assistant#11930)
  Fixed rfxtrx binary_sensor KeyError on missing optional device_class (home-assistant#11925)
  Allow setting climate devices to AUTO mode via Google Assistant (home-assistant#11923)
  fixes home-assistant#11848 (home-assistant#11915)
  Add "write" service to system_log (home-assistant#11901)
  Update frontend to 20180126.0
  Version 0.62
  Allow separate command and state OIDs and payloads in SNMP switch (home-assistant#11075)
  Add ERC20 tokens to etherscan.io sensor (home-assistant#11916)
  Report scripts and groups as scenes to Alexa (home-assistant#11900)
  Minor fix to configuration validation and related log line. (home-assistant#11898)
  Multi-Room Support for Greenwave Reality (home-assistant#11364)
  Added Xeoma camera platform (home-assistant#11619)
  Improve foscam library exception support (home-assistant#11701)
  Iota wallet (home-assistant#11398)
  New venstar climate component (home-assistant#11639)
  Update python-wink version and multiple wink fixes/updates. (home-assistant#11833)
  Use API to discover Hue if no bridges specified (home-assistant#11909)
  Clarify emulated hue warning (home-assistant#11910)
  ...
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants