Add "write" service to system_log #11901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A suggestion would be to put this under the system_log component and expose write as a service. That makes it even easier to use and it's also available to automations, which might be handy sometimes for troubleshooting I guess. |
|
Turning this into a service is a good idea. I'll wait for more opinions on whether to put in in core or system_log |
|
After more though I agree this should be a service in system_log |
|
Sound good. We should call it like |
|
I like this a lot ! |
andrey-git
changed the title
andrey-git
added
integration: system_log
Ready for review
and removed
integration: api
labels
pvizeli
approved these changes
Jan 26, 2018
|
Great work! 👍 |
balloob
pushed a commit
that referenced
this pull request
Jan 27, 2018
* Add API to write error log * Move write_error api to system_log.write service call * Restore empty line
Merged
matemaciek
pushed a commit
to matemaciek/home-assistant
that referenced
this pull request
Jan 27, 2018
* upstream/master: (465 commits) Update pyhomematic to 0.1.38 (home-assistant#11936) Implement Alexa temperature sensors (home-assistant#11930) Fixed rfxtrx binary_sensor KeyError on missing optional device_class (home-assistant#11925) Allow setting climate devices to AUTO mode via Google Assistant (home-assistant#11923) fixes home-assistant#11848 (home-assistant#11915) Add "write" service to system_log (home-assistant#11901) Update frontend to 20180126.0 Version 0.62 Allow separate command and state OIDs and payloads in SNMP switch (home-assistant#11075) Add ERC20 tokens to etherscan.io sensor (home-assistant#11916) Report scripts and groups as scenes to Alexa (home-assistant#11900) Minor fix to configuration validation and related log line. (home-assistant#11898) Multi-Room Support for Greenwave Reality (home-assistant#11364) Added Xeoma camera platform (home-assistant#11619) Improve foscam library exception support (home-assistant#11701) Iota wallet (home-assistant#11398) New venstar climate component (home-assistant#11639) Update python-wink version and multiple wink fixes/updates. (home-assistant#11833) Use API to discover Hue if no bridges specified (home-assistant#11909) Clarify emulated hue warning (home-assistant#11910) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add
system_log.writeserviceResult
2018-01-22 23:00:26 ERROR (MainThread) [mylogger] testThe first use-case for this is for the frontend to catch and report JS errors, however I think this API could be generally useful, and thus I'm not conditioning it on
frontendcomponent.Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass