-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BMW Target SoC to number platform #91081
Conversation
Hey there @gerard33, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hi @rikroe-hera It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
1 similar comment
Hi @rikroe-hera It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
acceb59
to
ba28a3f
Compare
ba28a3f
to
c701c5c
Compare
c701c5c
to
e97de99
Compare
e97de99
to
aea6e16
Compare
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
CI fails due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I added it to the milestone to avoid a breaking change. |
Just removed the string casting as frenck requested in #92199 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @rikroe 👍
../Frenck
Co-authored-by: Franck Nijhof <frenck@frenck.nl> Co-authored-by: rikroe <rikroe@users.noreply.github.com>
Proposed change
As requested by @MartinHjelmare in #88759 (comment), this PR adds the
NUMBER
platform to bmw_connected_drive and moves Target SoC there.No breaking change as #88759 was merged after the last beta cut, so it is not yet live.
Changelog:
Diff: bimmerconnected/bimmer_connected@0.13.0...0.13.2
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: