Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BMW Target SoC to number platform #91081

Merged
merged 7 commits into from
Apr 29, 2023

Conversation

rikroe
Copy link
Contributor

@rikroe rikroe commented Apr 8, 2023

Proposed change

As requested by @MartinHjelmare in #88759 (comment), this PR adds the NUMBER platform to bmw_connected_drive and moves Target SoC there.

No breaking change as #88759 was merged after the last beta cut, so it is not yet live.

Changelog:

Diff: bimmerconnected/bimmer_connected@0.13.0...0.13.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 8, 2023

Hey there @gerard33, mind taking a look at this pull request as it has been labeled with an integration (bmw_connected_drive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bmw_connected_drive can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign bmw_connected_drive Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant home-assistant bot marked this pull request as draft April 25, 2023 07:58
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hi @rikroe-hera

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

1 similar comment
@home-assistant
Copy link

Hi @rikroe-hera

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@rikroe
Copy link
Contributor Author

rikroe commented Apr 25, 2023

CI fails due to Error: API rate limit exceeded for installation ID 689304

@rikroe rikroe requested a review from frenck April 27, 2023 19:03
@rikroe rikroe marked this pull request as ready for review April 28, 2023 10:56
@home-assistant home-assistant bot marked this pull request as draft April 28, 2023 12:22
@rikroe rikroe marked this pull request as ready for review April 28, 2023 17:10
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2023.5.0 milestone Apr 28, 2023
@MartinHjelmare
Copy link
Member

I added it to the milestone to avoid a breaking change.

@rikroe
Copy link
Contributor Author

rikroe commented Apr 28, 2023

Just removed the string casting as frenck requested in #92199 (comment).
Otherwise no changes.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rikroe 👍

../Frenck

@frenck frenck merged commit 1028841 into home-assistant:dev Apr 29, 2023
frenck added a commit that referenced this pull request Apr 29, 2023
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: rikroe <rikroe@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2023
@rikroe rikroe deleted the bmw-target-soc-number branch December 21, 2023 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants