Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number to bmw_connected_drive documentation #27147

Merged
merged 3 commits into from
May 3, 2023

Conversation

rikroe
Copy link
Contributor

@rikroe rikroe commented Apr 26, 2023

Proposed change

Add documention on the new number entities for EV charging in BMW Connected Drive.

Needs an additional commit once #26365 is merged (delete one line from there).

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Apr 26, 2023
@rikroe
Copy link
Contributor Author

rikroe commented Apr 29, 2023

Hey @frenck, as home-assistant/core#91081 got merged into 2023.5 (thanks!), this should also be included.

@rikroe
Copy link
Contributor Author

rikroe commented Apr 30, 2023

Also, I was wondering if home-assistant/core#88759 and home-assistant/core#91081 could be seen as noteworthy change, as BMW/Mini EV owners now are able to control vehicle charging from HA.

@frenck frenck changed the base branch from next to current May 3, 2023 21:49
@home-assistant home-assistant bot removed the next This PR goes into the next branch label May 3, 2023
@home-assistant home-assistant bot added current This PR goes into the current branch in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 3, 2023
@home-assistant
Copy link

home-assistant bot commented May 3, 2023

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@frenck frenck added this to the 2023.5 milestone May 3, 2023
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label May 3, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rikroe 👍

../Frenck

@frenck frenck merged commit 6f284d1 into home-assistant:current May 3, 2023
@home-assistant home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels May 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked This PR has been manually picked and merged into the current branch current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants