-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(github): commit parity check to ignore dependabot pull requests #3469
Comments
Hi @petermetz Setting up as a part of Can we do something like this (less elegant, but least resource intensive way imo)? (My main focus point here is that having a |
@jagpreetsinghsasan Agreed on all counts. I think the hardcoded bot names are a good trade-off for now we only have dependabot on that list of bots anyway (that I know of). I also agree very much that the resource usage of it is already too high, ideally a baseline check like this wouldn't even need to run https://chatgpt.com/share/40999856-36eb-4f41-a841-2e0d6af37eca If we could make it so that the commit parity check is just a |
@petermetz I think the library we used also uses the same algorithm in the backend. True that the dependencies should not exist otherwise devs will just leave it as it is and move on the other tasks. I will implement the same (I haven't tried using LLMs outside generating images and posters, this is the first time I am seeing it code XD) |
Primary Changes --------------- 1. Updated the workflow to include a skip when the PR author is dependabot 2. Updated the pr-commit parity script to include Levenshtein Distance string metric instead of importing a package to reduce workflow runtime Changes required to incorporate 1) 3. Updated workflows/pr-commit-parity.yaml with a conditional statement Changes required to incorporate 2) 4. Updated the script with the functions, levensheteinDistance and stringSimilarity to have the required functionality 5. Updated the package.json with removal of the package dependency of string-similarity-js 6. Updated the workflow and removed steps to parse the project, thus reducing workflow runtime Fixes hyperledger#3469 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Primary Changes --------------- 1. Updated the workflow to include a skip when the PR author is dependabot 2. Updated the pr-commit parity script to include Levenshtein Distance string metric instead of importing a package to reduce workflow runtime Changes required to incorporate 1) 3. Updated workflows/pr-commit-parity.yaml with a conditional statement Changes required to incorporate 2) 4. Updated the script with the functions, levensheteinDistance and stringSimilarity to have the required functionality 5. Updated the package.json with removal of the package dependency of string-similarity-js 6. Updated the workflow and removed steps to parse the project, thus reducing workflow runtime Fixes hyperledger#3469 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Primary Changes --------------- 1. Updated the workflow to include a skip when the PR author is dependabot 2. Updated the pr-commit parity script to include Levenshtein Distance string metric instead of importing a package to reduce workflow runtime Changes required to incorporate 1) 3. Updated workflows/pr-commit-parity.yaml with a conditional statement Changes required to incorporate 2) 4. Updated the script with the functions, levensheteinDistance and stringSimilarity to have the required functionality 5. Updated the package.json with removal of the package dependency of string-similarity-js 6. Updated the workflow and removed steps to parse the project, thus reducing workflow runtime Fixes hyperledger#3469 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Primary Changes --------------- 1. Updated the workflow to include a skip when the PR author is dependabot 2. Updated the pr-commit parity script to include Levenshtein Distance string metric instead of importing a package to reduce workflow runtime Changes required to incorporate 1) 3. Updated workflows/pr-commit-parity.yaml with a conditional statement Changes required to incorporate 2) 4. Updated the script with the functions, levensheteinDistance and stringSimilarity to have the required functionality 5. Updated the package.json with removal of the package dependency of string-similarity-js 6. Updated the workflow and removed steps to parse the project, thus reducing workflow runtime Fixes hyperledger#3469 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Primary Changes --------------- 1. Updated the workflow to include a skip when the PR author is dependabot 2. Updated the pr-commit parity script to include Levenshtein Distance string metric instead of importing a package to reduce workflow runtime Changes required to incorporate 1) 3. Updated workflows/pr-commit-parity.yaml with a conditional statement Changes required to incorporate 2) 4. Updated the script with the functions, levensheteinDistance and stringSimilarity to have the required functionality 5. Updated the package.json with removal of the package dependency of string-similarity-js 6. Updated the workflow and removed steps to parse the project, thus reducing workflow runtime Fixes #3469 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Description
Dependabot pull requests are failing the PR commit parity check and the only way to fix them is by manually editing every pull request the bots make which is a drain on our resources and I'm not sure it's worth it for this particular category of pull requests. Here's why:
The dependabot pull requests are always the same in the sense that they are just bumping dependences so their complexity remains very low, forever.
With this in mind the easiest shortcut for us right now is to just add a configuration option to the commit parity check which allows us to tell it to ignore pull requests from certain authors (and for now the one item we'll put on that list is dependabot).
Acceptance Criteria
CACTI_CUSTOM_CHECK_PR_COMMIT_PARITY_EXEMPTED_AUTHORS=dependabot,some-other-bot-1,yet_another_bot_2,etc.
The text was updated successfully, but these errors were encountered: