Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): skip commit parity for bots #3521

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jagpreetsinghsasan
Copy link
Contributor

Commit to be reviewed

ci(github): skip commit parity for bots

Primary Changes
---------------
1. Updated the workflow to include a skip
   when the PR author is dependabot
2. Updated the pr-commit parity script to
   include Levenshtein Distance string metric
   instead of importing a package to reduce
   workflow runtime

Changes required to incorporate 1)
3. Updated workflows/pr-commit-parity.yaml with
   a conditional statement

Changes required to incorporate 2)
4. Updated the script with the functions,
   levensheteinDistance and stringSimilarity
   to have the required functionality
5. Updated the package.json with removal of the
   package dependency of string-similarity-js
6. Updated the workflow and removed steps to
   parse the project, thus reducing workflow
   runtime

Fixes #3469

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

    Primary Changes
    ---------------
    1. Updated the workflow to include a skip
       when the PR author is dependabot
    2. Updated the pr-commit parity script to
       include Levenshtein Distance string metric
       instead of importing a package to reduce
       workflow runtime

    Changes required to incorporate 1)
    3. Updated workflows/pr-commit-parity.yaml with
       a conditional statement

    Changes required to incorporate 2)
    4. Updated the script with the functions,
       levensheteinDistance and stringSimilarity
       to have the required functionality
    5. Updated the package.json with removal of the
       package dependency of string-similarity-js
    6. Updated the workflow and removed steps to
       parse the project, thus reducing workflow
       runtime

Fixes hyperledger#3469

Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
@petermetz petermetz merged commit 7b32791 into hyperledger:main Sep 9, 2024
145 of 148 checks passed
@petermetz petermetz deleted the feat-3469 branch September 9, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(github): commit parity check to ignore dependabot pull requests
3 participants