Tests of canonical xml input causing problems

[ietf-svn-bot]

owner:jennifer@painless-security.com resolution_fixed type_defect | by jennifer@painless-security.com

---

The fix to #664 introduced the file rfc9001.canonical.xml as a test of rendering a published "canonical" input file. Even after fixing an outright breakage (6460f4a), this addition is causing a couple of problems per rjsparks@nostrum.com:

The issue was that the new rfc9001.canonical.xml was getting picked up by the rule here:

https://trac.ietf.org/trac/xml2rfc/browser/trunk/cli/Makefile#L113

I worked around that with the rename of the input file - I hope there's a better way to signal that, future contributors will probably be confused by the canonicalxml run-on.

Maybe we should have a /canonicalinput/ directory beside /input/?

Also, the scaffolding for yestests doesn't seem to work right with the new file - I had to manually copy a "good" result to tests/valid.

---

Issue migrated from trac:671 at 2022-02-08 07:17:14 +0000

[ietf-svn-bot]

@jennifer@painless-security.com changed status from new to assigned

[ietf-svn-bot]

@jennifer@painless-security.com set owner to jennifer@painless-security.com

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

As discussed in email, I think the problem with l.113 of the Makefile is caused by different precedence when multiple rules match between GNU make versions. (For 3.81 and earlier, the first matching rule was chosen. For 3.82 and later, the rule with the shortest matched stem was chosen.) If I move the new rule earlier in the Makefile, both old and new should agree which rule "wins."

[ietf-svn-bot]

@jennifer@painless-security.com changed status from assigned to closed

[ietf-svn-bot]

@jennifer@painless-security.com set resolution to fixed

[ietf-svn-bot]

@jennifer@painless-security.com commented

---

Fixed in 9e59346:

Fix Makefile rule precedence and repair canonical.xml test to work with yestest. Fixes #671. Commit ready for merge.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in 34cbd4e:

Merged in 9e59346 from jennifer@painless-security.com:\n Fix Makefile rule precedence and repair canonical.xml test to work with yestest. Fixes #671.