Fix cross-compilation for armv6l #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tryTimed out |
|
bors try |
tryBuild succeeded |
hamishmack
pushed a commit
that referenced
this pull request
Oct 14, 2020
Fixes the #441 issue with GHC 8.8.3 (fix that was already applied to GHC 8.6.5 with PR #480). Testing environment: - GHC 8.8.3 (cross-compiler) - NixOS 20.03 - Building host: x86_64 - Target host: armv6l Without this PR, the symbol `__sync_val_compare_and_swap_8` was not found by `remote-iserv` as described in #441 but this time with GHC 8.8.3. The 8.6.5 patch also works for 8.8.3. Perhaps it would be preferable to apply this patch to a range of GHC versions rather than specific versions, but I have only tested it and verified that it works properly on those specific versions. I have not submitted this patch to the GHC GitLab as I haven't encountered any problem building a cross-compiling version of GHC from there.
booniepepper
pushed a commit
to booniepepper/haskell.nix
that referenced
this pull request
Feb 4, 2022
…tput-hk#857) Fixes the input-output-hk#441 issue with GHC 8.8.3 (fix that was already applied to GHC 8.6.5 with PR input-output-hk#480). Testing environment: - GHC 8.8.3 (cross-compiler) - NixOS 20.03 - Building host: x86_64 - Target host: armv6l Without this PR, the symbol `__sync_val_compare_and_swap_8` was not found by `remote-iserv` as described in input-output-hk#441 but this time with GHC 8.8.3. The 8.6.5 patch also works for 8.8.3. Perhaps it would be preferable to apply this patch to a range of GHC versions rather than specific versions, but I have only tested it and verified that it works properly on those specific versions. I have not submitted this patch to the GHC GitLab as I haven't encountered any problem building a cross-compiling version of GHC from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a patch for GHC 8.6.5 to properly remove the atomic primops fallbacks on ARM architectures. Those primops called some GCC legacy synchronization functions that were not loaded during TH, ending in failure within
remote-iserv. It turns out that the condition!defined(arm_HOST_ARCH)was nevertrue, asarm_HOST_ARCHwas actually defined (on ARM architectures) in a dependency of theRts.hfile.This patch works for my use case (GHC 8.6.5 for armv6l). I haven't done any test on the other GHC versions.
This PR also includes a patch to actually use the native
pkgconfigduring cross-compilation.Fixes #441