Refactor: signable builder services compute full protocol message #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
approved these changes
Sep 24, 2024
Alenar
reviewed
Sep 24, 2024
jpraynaud
force-pushed
the
jpraynaud/1941-refactor-signable-builder
branch
2 times, most recently
from
7fb6683
to
d445ce7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
approved these changes
Sep 24, 2024
mithril-common/src/signable_builder/signable_builder_service.rs
Outdated
Show resolved
Hide resolved
Which is responsible for computing the seed message that will be used by signable builders to compute their respective protocol messages.
…ableBuilder trait
…gregator integration test
…gner integration test
Rollback to the original trait.
…lues And let the responsibility of using it in the signable builder service.
…eedBuilder' in aggregator
…uilder' in signer
…sub-module of services in aggregator
…sub-module of services in signer
- 'mithril-aggregator' from '0.5.67' to '0.5.68' - 'mithril-common' from '0.4.57' to '0.4.58' - 'mithril-signer' from '0.2.186' to '0.2.187'.
jpraynaud
force-pushed
the
jpraynaud/1941-refactor-signable-builder
branch
from
ab51421
to
71fef49
Compare
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a refactoring of the signable builder service so that it computes the next aggregate verification key part of the protocol message instead of delegating this responsibility to the state machines runners in signer and aggregator.
A new
SignableSeedBuildertrait has been created which is responsible for computing part of the protocol message by theSignableBuilderservice to enrich it.Pre-submit checklist
Issue(s)
Closes #1941