Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: signable builder services compute full protocol message #1942

Merged
merged 33 commits into from
Sep 25, 2024
Merged

Refactor: signable builder services compute full protocol message #1942

merged 33 commits into from
Sep 25, 2024

Commits on Sep 24, 2024

  1. feat: introduce SignableSeedBuilder trait 

    Which is responsible for computing the seed message that will be used
by signable builders to compute their respective protocol messages.
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a81db87 View commit details
    Browse the repository at this point in the history

  2. feat: make SignableBuilder service use SignableSeedBuilder

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    01e6ac8 View commit details
    Browse the repository at this point in the history

  3. chore: adapt CardanoTransactionsSignableBuilder to updated SignableBu… 

    …ilder trait
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1e0afa7 View commit details
    Browse the repository at this point in the history

  4. chore: adapt CardanoImmutableFilesFullSignableBuilder to updated Sign… 

    …ableBuilder trait
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e4d4a4e View commit details
    Browse the repository at this point in the history

  5. chore: adapt CardanoStakeDistributionSignableBuilder to updated Signa… 

    …bleBuilder trait
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ca183be View commit details
    Browse the repository at this point in the history

  6. chore: adapt MithrilStakeDistributionSignableBuilder to updated Signa… 

    …bleBuilder trait
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5e3a66c View commit details
    Browse the repository at this point in the history

  7. feat: add SignableSeedBuilderService in aggregator

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6a7b554 View commit details
    Browse the repository at this point in the history

  8. feat: wire SignableSeedBuilderService in aggregator DI

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0336a6c View commit details
    Browse the repository at this point in the history

  9. chore: remove ad hoc signature of next avk for protocol message in ag… 

    …gregator runner
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8fffd14 View commit details
    Browse the repository at this point in the history

  10. chore: remove ad hoc signature of next avk for protocol message in ag… 

    …gregator integration test
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1e12457 View commit details
    Browse the repository at this point in the history

  11. feat: add SignableSeedBuilderService in signer

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8aa4db1 View commit details
    Browse the repository at this point in the history

  12. feat: wire SignableSeedBuilderService in signer DI

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6459e95 View commit details
    Browse the repository at this point in the history

  13. chore: remove ad hoc signature of next avk for protocol message in si… 

    …gner runner
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    aed8c61 View commit details
    Browse the repository at this point in the history

  14. chore: remove ad hoc signature of next avk for protocol message in si… 

    …gner integration test
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e3059bf View commit details
    Browse the repository at this point in the history

  15. test: add missing test for SignableSeedBuilder in aggregator

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a06a6d1 View commit details
    Browse the repository at this point in the history

  16. test: add missing test for SignableSeedBuilder in signer

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0e3b172 View commit details
    Browse the repository at this point in the history

  17. refactor: add Mock DI container in SignableBuilderService tests

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    637868b View commit details
    Browse the repository at this point in the history

  18. chore: apply review comments

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f080739 View commit details
    Browse the repository at this point in the history

  19. refactor: migrate EpochService mock in epoch service

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    88ae081 View commit details
    Browse the repository at this point in the history

  20. refactor: remove seed protocol message from signable builder 

    Rollback to the original trait.
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e30164e View commit details
    Browse the repository at this point in the history

  21. refactor: make signable seed builder use an existing protocol message

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    64dca07 View commit details
    Browse the repository at this point in the history

  22. refactor: make signable seed builder compute protocol message part va… 

    …lues

And let the responsibility of using it in the signable builder service.
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8af7ef7 View commit details
    Browse the repository at this point in the history

  23. refactor: rename 'SignableSeedBuilderService' to 'AggregatorSignableS… 

    …eedBuilder' in aggregator
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    695f694 View commit details
    Browse the repository at this point in the history

  24. refactor: rename 'SignableSeedBuilderService' to 'SignerSignableSeedB… 

    …uilder' in signer
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    cc2d75f View commit details
    Browse the repository at this point in the history

  25. fixup refactor: make signable seed builder compute protocol message p… 

    …art values
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    16a3ea0 View commit details
    Browse the repository at this point in the history

  26. refactor: move SignableSeedBuilder in a dedicated 'signable_builder' … 

    …sub-module of services in aggregator
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5c196f5 View commit details
    Browse the repository at this point in the history

  27. refactor: move SignableSeedBuilder in a dedicated 'signable_builder' … 

    …sub-module of services in signer
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    917a18c View commit details
    Browse the repository at this point in the history

  28. fix: handle merge conflicts with main branch

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c2a0f0e View commit details
    Browse the repository at this point in the history

  29. refactor: remove mentions to SignableSeedBuilder service in aggregato… 

    …r DI builder
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bdc3ad6 View commit details
    Browse the repository at this point in the history

  30. refactor: remove unused custom mock implementation in SignabeBuilder … 

    …tests
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    aecd8e3 View commit details
    Browse the repository at this point in the history

  31. refactor: rename 'mock' sub module of Epoch Service in 'mock_epoch_se… 

    …rvice'
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f4c22a1 View commit details
    Browse the repository at this point in the history

  32. docs: update CHANGELOG

    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    46bfc03 View commit details
    Browse the repository at this point in the history

  33. chore: bump crates versions 

    - 'mithril-aggregator' from '0.5.67' to '0.5.68'
- 'mithril-common' from '0.4.57' to '0.4.58'
- 'mithril-signer' from '0.2.186' to '0.2.187'.
    @jpraynaud
    jpraynaud committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    71fef49 View commit details
    Browse the repository at this point in the history