dependency update #764
Merged
dependency update #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason, this PR causes the deployment to not match the test: It shouldn't be "reusing existing lvm-testing" here. |
It's bit strange, it shouldn't reuse "lvm-testing" for running operator API tests. |
pohly
force-pushed
the
dependencies
branch
2 times, most recently
from
3654259
to
b4ca3f8
Compare
|
|
We need kubernetes-csi/csi-lib-utils#67 and must suppress |
The anonymous function is bound to the loop variables which change their content. This works with the current Ginkgo v1.12.1 where Describe calls the function immediately, but in Ginkgo v1.14.1 that changes and the function is stored and called much later. To prepare for that, each function instance must be bound to copies of the loop variables. Otherwise for example a test for "operator" runs with the deployment for "direct-testing".
This is the result of `go get -u ./...` with some manual tweaks: - gopkg.in/square/go-jose.v2@v2.2.2 and google.golang.org/grpc@v1.27.0 because that is what Kubernetes uses and newer versions changed the API such that Kubernetes code doesn't compile - github.com/operator-framework/operator-sdk/version was made an internal package, so we can't use it anymore - github.com/operator-framework/operator-sdk/pkg/restmapper was removed - we don't seem to need it anymore
When we get an unexpected status code like 500, the body contains an explanation of what went wrong.
To see log output, we must initialize the arguments and run the test with -v=5.
The new release adds support for process_start_time, which we don't need and don't want because we already get it through the Prometheus Golang collector. Worse, if we keep it enabled in the metrics manager, then metrics collection fails because the two definitions are slightly different, which Prometheus treats as an error.
|
@avalluri : this is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of
go get -u ./...with some manual tweaks:because that is what Kubernetes uses and newer versions
changed the API such that Kubernetes code doesn't compile
an internal package, so we can't use it anymore
removed - we don't seem to need it anymore
Fixes: #756