fix(android, dependencies): remove vestigial ml dependencies, add browser dep to auth #4873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reCAPTCHA auth flow requires androidx.browser but it is not specified as a transitive dependency upstream, so it crashes. I attempted to use as wide a version range as I felt safe, and provided an override if you specify "androidxBrowserVersion" in your android/build.gradle ext config block Related #4744 Related firebase/firebase-android-sdk#2164 This may be removed when the upstream issue is closed.
image labeling on device is no longer supported but we were still referencing some on-device dependencies, causing the built APKs to be larger than necessary when they included the underlying native libraries Fixes #4750
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/emcysni9v |
Codecov Report
@@ Coverage Diff @@
## master #4873 +/- ##
===========================================
- Coverage 89.06% 36.87% -52.19%
===========================================
Files 109 48 -61
Lines 3720 1454 -2266
Branches 347 347
===========================================
- Hits 3313 536 -2777
- Misses 365 697 +332
- Partials 42 221 +179 |
…minimum 3.5.3, which comes default with react-native@0.63.x still, has AAPT failures
mikehardy
force-pushed
the
@mikehardy/android-dependency-fixes
branch
from
318fcff
to
707631d
Compare
|
also snuck a note in there about in-app-messaging needing android gradle plugin 3.5.4 as a minimum, discovered in testing all of these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Android dependencies in ML were still pulling in an on-device library, unnecessarily bloating APKs, #4750 / #4871
Auth module depends on androidx.browser for reCAPTCHA flow but it is not included transitively from upstream, this leads to crashes so including a workaround here while upstream issue resolves seems reasonable, #4744 / firebase/firebase-android-sdk#2164
Release Summary
This should be re-base merged, each commit has a correct commit title
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter