Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android, dependencies): remove vestigial ml dependencies, add browser dep to auth #4873

Merged
merged 3 commits into from
Feb 5, 2021
Merged

fix(android, dependencies): remove vestigial ml dependencies, add browser dep to auth #4873

merged 3 commits into from
Feb 5, 2021

Commits on Feb 5, 2021

  1. fix(auth, android): add browser dependency as crash workaround 

    The reCAPTCHA auth flow requires androidx.browser but it is not specified
as a transitive dependency upstream, so it crashes.

I attempted to use as wide a version range as I felt safe, and provided an
override if you specify "androidxBrowserVersion" in your android/build.gradle
ext config block

Related #4744
Related firebase/firebase-android-sdk#2164

This may be removed when the upstream issue is closed.
    @mikehardy
    mikehardy committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    56c653e View commit details
    Browse the repository at this point in the history

  2. fix(ml, android): remove unnecessary on-device dependencies 

    image labeling on device is no longer supported but we were still
referencing some on-device dependencies, causing the built APKs to be
larger than necessary when they included the underlying native libraries

Fixes #4750
    @mikehardy
    mikehardy committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    d4ef115 View commit details
    Browse the repository at this point in the history

  3. docs(in-app-messaging, android): note android gradle plugin 3.5.4 is … 

    …minimum

3.5.3, which comes default with react-native@0.63.x still, has AAPT failures
    @mikehardy
    mikehardy committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    707631d View commit details
    Browse the repository at this point in the history