refactor: remove deprecated "ipfs on PATH" feature #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
changed the title
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
force-pushed
the
remove-ipfs-path
branch
from
4dd36f9
to
5d7b486
Compare
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Closed
lidel
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Thanks!
Merging, as I believe we should ship this.
It does its best to clean up any remaining cruft for legacy users, but does not impact new ones.
(I did not bother to add i18n, assuming CLI users don't mind one-time message in English, since our CLI is only in English anyway)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (almost) completely removes the feature 'IPFS on PATH'. This feature was officially deprecated in #1768 and only stayed active for users that had it enabled.
Even while deprecated, this feature is creating problems (see #1943). This PR completely uninstalls IPFS on PATH for the users that still have it enabled and shows this little message:
Fixes #1943
Closes #1969
In a few versions, we should remove the uninstall code. I think it is wise to keep for now so that it reverts the changes that it made before.