Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated ipfs-on-path, npm-on-ipfs #2140

Merged
merged 1 commit into from
May 26, 2022

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented May 13, 2022

Back in February 2021, we deprecated ipfs-on-path (#1768) and in January 2022 we added some code to uninstall both features completely (#1948, #1947).

Since @SgtPooki is working on many maintenance improvements right now, I thought it'd be a great time to get rid of this chunk of code that is deprecated. It also decreases the scope of some other maintenance issues as there won't be a need to touch this code anymore.

Closes #1935

@hacdias hacdias requested review from lidel and SgtPooki May 13, 2022 11:32
@hacdias hacdias force-pushed the chore/remove-deprecated-features branch from f14437c to 6267fe7 Compare May 13, 2022 11:35
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias force-pushed the chore/remove-deprecated-features branch from 32c8dbc to b39ccf5 Compare May 13, 2022 11:37
@hacdias
Copy link
Member Author

hacdias commented May 16, 2022

FYI: the webui test has been timing out while downloading IPFS Web UI via npx ipfs-or-gateway.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, thank you for cleaning this up! (cc #1768)

@lidel lidel merged commit e77083e into main May 26, 2022
@lidel lidel deleted the chore/remove-deprecated-features branch May 26, 2022 12:30
@lidel lidel mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

From where it assumes the user home path?
2 participants