[Bug]: badger as sampling store not work #4963
Labels
Comments
|
Should've been solved by #4834 -- cc @slayer321 |
4 tasks
|
@saletnik Implemented CreateLock method, earlier while working on the #4834 I totally missed Implementing that , I think as there was not lock required for badgerdb that was the reason I missed it. @yurishkuro I have create a new PR with the changes PTAL |
yurishkuro
added a commit
that referenced
this issue
Nov 26, 2023
## Which problem is this PR solving? - Part of #4963 - Follow up to #4834 ## Description of the changes - Explicitly declare all interfaces each factory implements - Move these declarations to the main file for visibility ## How was this change tested? - CI Signed-off-by: Yuri Shkuro <github@ysh.us>
|
now it is working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
Error starting "storage factory of type badger does not support sampling store"
badger storage not implement SamplingStoreFactory interface -> no method CreateLock
Steps to reproduce
docker run --rm --env SAMPLING_STORAGE_TYPE=badger --env SAMPLING_CONFIG_TYPE=adaptive jaegertracing/all-in-one:1.51.0
Expected behavior
work with badger as sampling store
Relevant log output
No response
Screenshot
No response
Additional context
No response
Jaeger backend version
v1.51.0
SDK
No response
Pipeline
No response
Stogage backend
badger
Operating system
Linux
Deployment model
Docker
Deployment configs
No response
The text was updated successfully, but these errors were encountered: