Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(badger): Add missing SamplingStoreFactory.CreateLock method #4966

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

slayer321
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Implement missing CreateLock method on SamplingStoreFactory interface for badger

How was this change tested?

  • run the Integration and make test command

Checklist

@slayer321 slayer321 requested a review from a team as a code owner November 26, 2023 09:07
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (076cd87) 95.59% compared to head (5f7fe8f) 95.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4966      +/-   ##
==========================================
+ Coverage   95.59%   95.60%   +0.01%     
==========================================
  Files         317      318       +1     
  Lines       18689    18695       +6     
==========================================
+ Hits        17866    17874       +8     
+ Misses        661      659       -2     
  Partials      162      162              
Flag Coverage Δ
cassandra-3.x 25.64% <ø> (ø)
cassandra-4.x 25.64% <ø> (ø)
elasticsearch-5.x 19.91% <ø> (ø)
elasticsearch-6.x 19.91% <ø> (ø)
elasticsearch-7.x 20.05% <ø> (ø)
elasticsearch-8.x 20.12% <ø> (-0.02%) ⬇️
grpc-badger 19.53% <0.00%> (-0.02%) ⬇️
kafka 14.07% <ø> (ø)
opensearch-1.x 20.05% <ø> (ø)
opensearch-2.x 20.05% <ø> (+0.01%) ⬆️
unittests 93.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

@slayer321 this issue should've been caught at compile time, and via integration test, but it looks like this PR is not changing any of those. The storage factory must implement this interface

type SamplingStoreFactory interface {

I think the issue with integration tests is that the StorageIntegration struct is defined with direct access to SpanWriter etc. that are pre-initialized by the concrete implementation. Instead it would be better if implementations would only initialize the respective factories and let the test retrieve writer, etc. (we could do it in another PR).

@yurishkuro
Copy link
Member

Cf: #4967

@yurishkuro yurishkuro changed the title fix: implement CreateLock method on SamplingStoreFactory interface for badger fix(badger): Add missing SamplingStoreFactory.CreateLock method Nov 26, 2023
…r badger

Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
@yurishkuro yurishkuro merged commit 115c692 into jaegertracing:main Nov 27, 2023
37 checks passed
@yurishkuro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: badger as sampling store not work
2 participants