Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single shared set of CA, client & server keys/certs for testing #2343

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Use a single shared set of CA, client & server keys/certs for testing #2343

merged 1 commit into from
Jul 15, 2020

Conversation

rjs211
Copy link
Contributor

@rjs211 rjs211 commented Jul 15, 2020

Signed-off-by: rjs211 srivatsa211@gmail.com

Which problem is this PR solving?

  • currently, there are two versions of certificates used for for testing. This is redundant

Short description of the changes

  • consolidate the certificates needed for any secure client-server channel used during testing.
  • Added README.md for creation of CA, client, server keys and certificates

Signed-off-by: rjs211 <srivatsa211@gmail.com>
@rjs211 rjs211 requested a review from a team as a code owner July 15, 2020 02:34
@rjs211 rjs211 requested a review from vprithvi July 15, 2020 02:34
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #2343 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2343      +/-   ##
==========================================
- Coverage   95.65%   95.64%   -0.01%     
==========================================
  Files         205      205              
  Lines       10529    10529              
==========================================
- Hits        10071    10070       -1     
  Misses        392      392              
- Partials       66       67       +1     
Impacted Files Coverage Δ
cmd/query/app/server.go 90.90% <0.00%> (-2.28%) ⬇️
plugin/storage/integration/integration.go 80.38% <0.00%> (-0.48%) ⬇️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27c5514...d09735e. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉 🎉 🎉

@@ -41,6 +41,8 @@ collectorHostPorts:
- 127.0.0.1:14269
`

var testCertKeyLocation = "../../../../../pkg/config/tlscfg/testdata/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trailing / not needed

@yurishkuro yurishkuro changed the title creating CA, client & server keys and certifs for testing Use a single shared set of CA, client & server keys/certs for testing Jul 15, 2020
@yurishkuro
Copy link
Member

Tip: take a look at CONTRIBUTING.md for guidelines on PR/commit titles. I renamed this one.

@yurishkuro yurishkuro merged commit 3ac7844 into jaegertracing:master Jul 15, 2020
@rjs211 rjs211 deleted the dev-TLSCertifs branch July 16, 2020 04:33
@rjs211 rjs211 restored the dev-TLSCertifs branch August 13, 2020 16:17
@rjs211 rjs211 deleted the dev-TLSCertifs branch August 13, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants