Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validity of TLS certificates to 3650 days #2390

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Update validity of TLS certificates to 3650 days #2390

merged 2 commits into from
Aug 13, 2020

Conversation

rjs211
Copy link
Contributor

@rjs211 rjs211 commented Aug 13, 2020

Signed-off-by: rjs211 srivatsa211@gmail.com

Which problem is this PR solving?

  • TLS certificate validity expired for example certificates

Short description of the changes

  • Previously, the default duration of validity (30 days) was used for generating certificates. This PR increases it to 3650 days or 10 years

Signed-off-by: rjs211 <srivatsa211@gmail.com>
@rjs211 rjs211 requested a review from a team as a code owner August 13, 2020 16:48
@rjs211 rjs211 requested a review from vprithvi August 13, 2020 16:49
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rjs211
Copy link
Contributor Author

rjs211 commented Aug 13, 2020

#2343 It was my blunder in the first place. Apologies.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #2390 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
+ Coverage   95.60%   95.62%   +0.02%     
==========================================
  Files         206      206              
  Lines       10547    10547              
==========================================
+ Hits        10083    10086       +3     
+ Misses        396      393       -3     
  Partials       68       68              
Impacted Files Coverage Δ
plugin/storage/integration/integration.go 80.86% <0.00%> (+0.47%) ⬆️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f8fe44...fee445f. Read the comment docs.

@yurishkuro yurishkuro merged commit 5daae75 into jaegertracing:master Aug 13, 2020
@rjs211 rjs211 deleted the dev-changeTLS branch January 28, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants