Close #3270: Prevent rollover lookback from passing the Unix epoch #3299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Unix epoch Version 1.26 introduced an automatic configuration for the query lookback when using ElasticSearch with aliases enabled. When aliases are enabled, the ES plugin will look back 100 years. This pre-dates the Unix epoch, and while such dates can be modeled as negative timestamps, the model defined in `jaeger/model/time.go` only supports unsigned timestamps. As a result, the 100-year lookback ends up overflowing the time model, resulting in a distant-future lookback date, rather than a distant-past lookback date. While the time model could be updated to support negative timestamps, it seems unlikely that any Jaeger users would reasonably need to search for spans from the 1920s. This reduces the automatic lookback to 50 years to remove the overflow issue while still providing an extremely long search window that should serve even the most ambitious searches of historical trace data. Signed-off-by: Charles Treatman <charles_treatman@comcast.com>
ctreatma
force-pushed
the
fix-es-alias-lookback
branch
from
821d51a
to
a043395
Compare
|
@ctreatma great fix :) Could you please sign the commits (DCO check)? https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#certificate-of-origin---sign-your-work |
pavolloffay
previously approved these changes
Oct 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #3299 +/- ##
==========================================
+ Coverage 95.81% 95.84% +0.03%
==========================================
Files 259 259
Lines 15413 15413
==========================================
+ Hits 14768 14773 +5
+ Misses 554 551 -3
+ Partials 91 89 -2
Continue to review full report at Codecov.
|
albertteoh
previously approved these changes
Oct 1, 2021
Signed-off-by: Charles Treatman <charles_treatman@comcast.com>
ctreatma
force-pushed
the
fix-es-alias-lookback
branch
from
11d1d8f
to
baab745
Compare
pavolloffay
approved these changes
Oct 4, 2021
|
What's the workaround until this is released? Downgrade to 1.25? |
@oliversalzburg in case you missed the notification, this fix is now available in release 1.27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #3270
Short description of the changes
Version 1.26 introduced an automatic configuration for the query lookback
when using ElasticSearch with aliases enabled. When aliases are enabled,
the ES plugin will look back 100 years. This pre-dates the Unix epoch, and
while such dates can be modeled as negative timestamps, the model defined
in
jaeger/model/time.goonly supports unsigned timestamps. As a result,the 100-year lookback ends up overflowing the time model, resulting in a
distant-future lookback date, rather than a distant-past lookback date.
While the time model could be updated to support negative timestamps, it
seems unlikely that any Jaeger users would reasonably need to search for
spans from the 1920s. This reduces the automatic lookback to 50 years to
remove the overflow issue while still providing an extremely long search
window that should serve even the most ambitious searches of historical
trace data.