Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #3270: Prevent rollover lookback from passing the Unix epoch #3299

Merged
merged 2 commits into from
Oct 4, 2021

Commits on Sep 30, 2021

  1. Close jaegertracing#3270: Prevent rollover lookback from passing the …

    …Unix epoch
    
    Version 1.26 introduced an automatic configuration for the query lookback
    when using ElasticSearch with aliases enabled.  When aliases are enabled,
    the ES plugin will look back 100 years.  This pre-dates the Unix epoch, and
    while such dates can be modeled as negative timestamps, the model defined
    in `jaeger/model/time.go` only supports unsigned timestamps.  As a result,
    the 100-year lookback ends up overflowing the time model, resulting in a
    distant-future lookback date, rather than a distant-past lookback date.
    
    While the time model could be updated to support negative timestamps, it
    seems unlikely that any Jaeger users would reasonably need to search for
    spans from the 1920s.  This reduces the automatic lookback to 50 years to
    remove the overflow issue while still providing an extremely long search
    window that should serve even the most ambitious searches of historical
    trace data.
    
    Signed-off-by: Charles Treatman <charles_treatman@comcast.com>
    ctreatma committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    a043395 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. Update test for maxSpanAge when aliases are enabled

    Signed-off-by: Charles Treatman <charles_treatman@comcast.com>
    ctreatma committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    baab745 View commit details
    Browse the repository at this point in the history