-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Servlet api issue 175 add cookie set attribute v3 #401
Merged
gregw
merged 15 commits into
jakartaee:master
from
gregw:servlet-api-issue-175_add-cookie-setAttribute-v3
May 17, 2021
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5bb8145
Add Cookie#setAttribute
BalusC 6efffc6
Merge branch 'master' of git@github.com:BalusC/servlet-api.git
BalusC 5fb98a5
Skip null value from check for reserved token
BalusC 3493d02
Alternative approach to cookie attribute handling
BalusC d5ec45f
Make sure path is referenced via constant
BalusC 5d98584
In hindsight, token check doesn't need to be performed on value
BalusC bda9697
Merge remote-tracking branch 'origin/servlet-api-issue-175_add-cookie…
BalusC 0c58ccd
Match casing with spec; mapping is case insensitive anyway
BalusC 597c87c
Optimized Cookie to lazily create attribute map
gregw 6201792
Added junit test
gregw 5754e4e
Updates from review
gregw f407bb4
Fixed quote
gregw 9e58b99
surefire plugin
gregw 2a80335
Updates from review
gregw 187cc61
Updates from review
gregw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move these to a section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move the versions to properties?