[JENKINS-34438] Activate JSHint through js-builder #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .withExternalModuleMapping('jquery-detached', 'core-assets/jquery-detached:jquery2') | ||
| .withExternalModuleMapping('bootstrap', 'core-assets/bootstrap:bootstrap3') | ||
| .withExternalModuleMapping('handlebars', 'core-assets/handlebars:handlebars3') | ||
| .inDir('src/main/webapp/jsbundles'); |
There was a problem hiding this comment.
Unrelated /cc @kzantow
|
🐝 after passing build ;) |
|
🐝 when #2368 gets merged |
oleg-nenashev
added
the
work-in-progress
|
@reviewbybees done |
|
The build is failing (unrelated with these changes) |
oleg-nenashev
added
needs-more-reviews
|
RE-:bee: |
oleg-nenashev
added
ready-for-merge
recena
changed the title
recena
referenced
this pull request
May 27, 2016
oleg-nenashev
added a commit
that referenced
this pull request
Jun 4, 2016
samatdav
pushed a commit
to samatdav/jenkins
that referenced
this pull request
Jul 25, 2016
samatdav
pushed a commit
to samatdav/jenkins
that referenced
this pull request
Jul 25, 2016
samatdav
pushed a commit
to samatdav/jenkins
that referenced
this pull request
Jul 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #2289
Downstream of #2368
With this PR we use JSHint through
js-builderand its configuration provided by default.@reviewbybees esp. @tfennelly