[JENKINS-35190] Do not invoke PingFailureAnalyzer for agent=>master ping failures #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🐝 |
| /** Keep in a separate method so we do not even try to do class loading on {@link PingFailureAnalyzer} from an agent JVM. */ | ||
| private void analyze(Throwable cause) throws IOException { | ||
| for (PingFailureAnalyzer pfa : PingFailureAnalyzer.all()) { | ||
| pfa.onPingFailure(channel,cause); |
There was a problem hiding this comment.
If you modify this code, please add handling of Runtime Exceptions
There was a problem hiding this comment.
It would be nice, though (a) there are no implementations to test, as noted in the description, (b) I spent some time testing the patch as written and would have to spend more time retesting with any other modifications.
|
🐝 with a comment related to the legacy code |
oleg-nenashev
changed the title
|
We also have +1 from Oliver, so I'm going to merge it . #2341 will be integrated manually since it makes sense in any case |
samatdav
pushed a commit
to samatdav/jenkins
that referenced
this pull request
Jul 25, 2016
… on the agent side. (jenkinsci#2377)
samatdav
pushed a commit
to samatdav/jenkins
that referenced
this pull request
Jul 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkinsci/remoting#85.
@reviewbybees