Support PHP 5.6

[jonahgeorge]

No description provided.

[jcchavezs]

I believe main need here is to have as much test coverage as possible.

[jonahgeorge]

PHP 5.6 is no longer actively supported and will stop being supported for security updates by end of year.

http://php.net/supported-versions.php

[jonahgeorge]

Reopening this as it's part of the consideration for migrating into jaegertracing org

[blong14]

@jonahgeorge I can take a look at this one. The plan would be to wire up some documentation on how to test different PHP versions via docker (docker run --rm...) for local testing. Add the necessary PHP version constraint to travis. Finally, update the code where necessary. Thoughts?

[blong14]

@jcchavezs what state is your branch in that adds support for 5.6?

[jonahgeorge]

With the release of 0.3.0, almost all code has at least a partial test and type hints in the docblock- so adding support for 5.6 should be as simple as removing the primitive type hints in the function signatures.

I'm not convinced that adding a docker setup is necessary as long as Travis has 5.6 in the test matrix. I would imagine most people will just install another version of PHP and switch their symlinks.

[blong14]

I was just thinking adding to the README how one could run a container to test a specific version of php, so there wouldn't be any code to include Dockerfiles or anything like, but having it in travis is fine.

[jonahgeorge]

Ah, gotcha. Documentation around running different PHP version via Docker in the README or something like TESTING.md would be perfect

[benkeil]

+1

[blong14]

@jonahgeorge I'm working out things for this. Not yet ready for a pull request but I think some feedback would be nice.

Diff with master

[blong14]

Also, once composer is updated appropriately for all versions pull request will be issued. Once merged I'll start working on the application code updates to handle changes necessary for 5.6.