REM [php] Remove support for PHP 5.6 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with this. @jonahgeorge can we remove PHP 5.6 support since this has never been fully implemented? @fredipevcin There is also roadmap https://github.com/jonahgeorge/jaeger-client-php/blob/master/README.md#roadmap regarding PHP 5.6 support |
|
@sergeyklay sorry I've missed the #11 issue. You can close this PR if there will be some development for PHP 5.6. |
|
Yea, lets kill it. PHP 5.6 is officially dead at the end of the year and there's been no more development to add support. Want to also remove from roadmap? |
|
If you agree on that I can do it. |
fredipevcin
force-pushed
the
remove-php-5.6
branch
from
76ec606
to
7a566dc
Compare
Library is using return type declarations which are supported only from PHP version 7. Closes jonahgeorge#11 as not implmeneted.
fredipevcin
force-pushed
the
remove-php-5.6
branch
from
7a566dc
to
31298c3
Compare
jonahgeorge
approved these changes
Sep 19, 2018
|
Thanks @fredipevcin !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library is using return type declarations which are supported only from
PHP version 7.
refs: #11