Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REM [php] Remove support for PHP 5.6 #68

Merged
merged 1 commit into from
Sep 19, 2018
Merged

REM [php] Remove support for PHP 5.6 #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ dist: trusty
language: php

php:
- '5.6'
- '7.0'
- '7.1'
- '7.2'
Expand All @@ -16,7 +15,6 @@ git:
matrix:
fast_finish: true
allow_failures:
- php: '5.6'
- php: nightly

install:
Expand Down
5 changes: 2 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ use OpenTracing\GlobalTracer;
$config = new Config(
[
'sampler' => [
'type' => 'const',
'type' => 'const',
'param' => true,
],
'logging' => true,
Expand All @@ -55,15 +55,14 @@ Tests are located in the `tests` directory. See [tests/README.md](./tests/README
## Roadmap

- [Support Span baggage](https://github.com/jonahgeorge/jaeger-client-php/issues/5)
- [Support PHP Version 5.6](https://github.com/jonahgeorge/jaeger-client-php/issues/11)
- [Support Tracer metrics](https://github.com/jonahgeorge/jaeger-client-php/issues/12)
- [Support Tracer error reporting](https://github.com/jonahgeorge/jaeger-client-php/issues/13)

## License

[MIT License](./LICENSE).

[ci-img]: https://travis-ci.org/jonahgeorge/jaeger-client-php.svg?branch=travis
[ci-img]: https://travis-ci.org/jonahgeorge/jaeger-client-php.svg?branch=travis
[ci]: https://travis-ci.org/jonahgeorge/jaeger-client-php
[packagist-img]: https://badge.fury.io/ph/jonahgeorge%2Fjaeger-client-php.svg
[packagist]: https://badge.fury.io/ph/jonahgeorge%2Fjaeger-client-php
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
}
],
"require": {
"php": "^5.6 || ^7.0",
"php": "^7.0",
"ext-sockets": "*",
"opentracing/opentracing": "1.0.0-beta5",
"packaged/thrift": "^0.10",
Expand All @@ -34,7 +34,7 @@
"opentracing/opentracing": "1.0.0-beta5"
},
"require-dev": {
"phpunit/phpunit": "~5.6 || ^6.4",
"phpunit/phpunit": "^6.4",
"squizlabs/php_codesniffer": "3.*"
},
"config": {
Expand Down
2 changes: 0 additions & 2 deletions tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ This folder includes all the unit tests that test Jaeger components, ensuring th

| version | status |
|---------|--------|
| 5.6 | 𝙓 |
| 7.0 | ✔ |
| 7.1 | ✔ |
| 7.2 | ✔ |
Expand Down Expand Up @@ -40,7 +39,6 @@ There is also an ability to run tests for different PHP versions. To achieve thi
[docker](https://docs.docker.com/install/)-based approach:

```bash
$ docker run --rm -it -v $(pwd):/usr/app php:5.6 ./usr/app/tests/php-test.sh

$ docker run --rm -it -v $(pwd):/usr/app php:7.0 ./usr/app/tests/php-test.sh

Expand Down