Bugfix - Explicit Time Zone assignment regression from #532 #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasn't passing in the timezone. Fixing...
a common constant for later reference.
prone reusability and easier cross-class documentation
objects with different TZs
|
Took a few tries to catch all the places where we were "doing it wrong", but it's good now. Thank god for tests... /cc: @koenpunt @jpfuentes2 |
This was referenced May 19, 2016
| * | ||
| * @var string | ||
| */ | ||
| const DATETIME_TRANSLATE_FORMAT = 'Y-m-d\TH:i:s'; |
There was a problem hiding this comment.
It's just the RFC 3339 format without the timezone identifier. I figured it was the most easily (standardized, spec-based) identifiable format. It doesn't really matter, though, as it's just for internal translations (not for storage, etc).
|
Thanks @jpfuentes2. Tests FTW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So PR #533 was fantastic in fixing an issue regarding passing in an explicit time-zone during column casting and attribute assigning. Unfortunately, the merge of #532 caused a regression as it overwrote the fix made in #533. 😞
This PR fixes that regression.
The included test makes sure the behavior is correct, and the following snippet demonstrates the issue at hand: