Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix - Explicit Time Zone assignment regression from #532 #539

Merged
merged 7 commits into from
May 20, 2016
Merged

Bugfix - Explicit Time Zone assignment regression from #532 #539

merged 7 commits into from
May 20, 2016

Commits on May 19, 2016

  1. Adding tests for the expected behavior

    @Rican7
    Rican7 committed May 19, 2016
    3 Configuration menu
    Copy the full SHA
    da5d27a View commit details
    Browse the repository at this point in the history

  2. Fixing the format used when converting DateTime 

    instances
    @Rican7
    Rican7 committed May 19, 2016
    Configuration menu
    Copy the full SHA
    db2e00a View commit details
    Browse the repository at this point in the history

  3. Adding comment to prevent further regression

    @Rican7
    Rican7 committed May 19, 2016
    Configuration menu
    Copy the full SHA
    f82ed61 View commit details
    Browse the repository at this point in the history

  4. The ActiveRecord\DateTime::createFromFormat() 

    wasn't passing in the timezone. Fixing...
    @Rican7
    Rican7 committed May 19, 2016
    Configuration menu
    Copy the full SHA
    e0cfce7 View commit details
    Browse the repository at this point in the history

  5. Fixing the issue in "Connection" too while making 

    a common constant for later reference.
    @Rican7
    Rican7 committed May 19, 2016
    Configuration menu
    Copy the full SHA
    b283d43 View commit details
    Browse the repository at this point in the history

  6. Now using the shared constant for a less error 

    prone reusability and easier cross-class documentation
    @Rican7
    Rican7 committed May 19, 2016
    Configuration menu
    Copy the full SHA
    0f6bcaf View commit details
    Browse the repository at this point in the history

  7. PHPUnit 3.7 can't correctly compare DateTime 

    objects with different TZs
    @Rican7
    Rican7 committed May 19, 2016
    Configuration menu
    Copy the full SHA
    c20a4e0 View commit details
    Browse the repository at this point in the history